Add the get-tokens command #56
Conversation
|
Lol, well we've got a roughed out API call here now. I'm hoping to get to the json parsing this evening. Maybe add real values instead of the hard coded configuration. |
xer0x
force-pushed
the
a0cli-20-token
branch
2 times, most recently
from
02b69f7 to
077c542
Compare
|
Updated the PR to move the command into @cyx anything more to update here? |
internal/cli/utils_shared.go
Outdated
| tenant, err := cli.getTenant() | ||
| if err != nil { | ||
| return tokenResponse, err | ||
| } |
There was a problem hiding this comment.
We already do this at the top of the command itself, could we just pass the tenant in to this function perhaps?
There was a problem hiding this comment.
Change the code to pass an extra tenant parameter to runClientCredentialsFlow()
internal/cli/utils_shared.go
Outdated
| cli.renderer.Infof("Domain: " + tenant.Domain) | ||
| cli.renderer.Infof("ClientID: " + clientID) | ||
| cli.renderer.Infof("Type: Machine to Machine") | ||
| fmt.Println() |
There was a problem hiding this comment.
This will print to stdout which might mess with piping the result to another process (like jq), have you tried that?
There was a problem hiding this comment.
jq won't be confused by whitespace.
However, we could switch to cli.renderer.Infof("") if that would be prettier. I didn't use it because it would put the green triangle.
There was a problem hiding this comment.
🤔 actually, it would be nice if auth0 get-token --format json would output only json. Do you know if the tool already has logic like this? Seeing an example of the tool hiding output would be great.
There was a problem hiding this comment.
So that's what this line is doing https://github.com/auth0/auth0-cli/pull/56/files#diff-32da9d2d97d78dec736cae68c2195111921918696567466ad99f78a291237298R52
fmt.Fprint(cli.renderer.MessageWriter, "\n") MessageWriter goes to stderr, while ResultWriter goes to stdout. That means we can print whatever we want to stderr but the only things that'll get piped onwards are results printed via the results writer.
A --quiet flag or similar might be a good addition though, avoid even writing the informational stuff to stderr.
There was a problem hiding this comment.
Awesome! Okay that helps. Thanks Paddy
There was a problem hiding this comment.
The STDOUT split seems to work
$ go run ./cmd/auth0 get-token --audience https://cli.test.auth0.fake --client-id wgxFPH6hY3JRwYjAjiFUxU9sjxNheLOm --format json > /dev/null | jq '.access_token' | pbcopy
...token is on my clipboard! ready to paste into Insomnia
internal/cli/utils_shared.go
Outdated
| cli.renderer.Infof("Domain: " + tenant.Domain) | ||
| cli.renderer.Infof("ClientID: " + clientID) | ||
| cli.renderer.Infof("Type: Machine to Machine") |
There was a problem hiding this comment.
This might be useful at the command-level, so it works for both types of flow, have you considered moving it up there?
internal/cli/utils_shared.go
Outdated
|
|
||
| // TODO: Check if the audience is valid, and suggest a different client if it is wrong. | ||
|
|
||
| payload := strings.NewReader("grant_type=client_credentials&client_id=" + clientID + "&client_secret=" + client_secret + "&audience=" + audience) |
There was a problem hiding this comment.
You can use url.Values to avoid building up the payload string manually, it'll also take care of all sorts of encoding edge cases for you.
internal/cli/utils_shared.go
Outdated
|
|
||
| var tokenResponse *authutil.TokenResponse | ||
|
|
||
| url := "https://" + tenant.Domain + "/oauth/token" |
There was a problem hiding this comment.
You can use url.URL here, might be safer/cleaner than building the URL manually, there's an example at https://github.com/auth0/auth0-cli/blob/main/internal/auth/authutil/login.go#L34
There was a problem hiding this comment.
yes! I was feeling like there must be a better way!
internal/cli/utils_shared.go
Outdated
| req, _ := http.NewRequest("POST", url, payload) | ||
|
|
||
| req.Header.Add("content-type", "application/x-www-form-urlencoded") | ||
|
|
||
| res, err := http.DefaultClient.Do(req) |
There was a problem hiding this comment.
Might http.PostForm be a little cleaner here/more succinct? there's an example at https://github.com/auth0/auth0-cli/blob/main/internal/auth/auth.go#L89-L98
There was a problem hiding this comment.
PostForm?! What's this? Hello new friend.
Description
Adds a command to get a token that can be used to access an API via curl, postman, insomnia, etc.
References
Screenshot
Unfortunately, the output has some extra whitespace around the token. :/
Testing
Checklist
master