feat: add name flag support for rules delete command #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ensure id and name flags are mutually exclusive - added rule id pattern check - fixed bug that didn't report not found rule when id was used Close A0CLI-40
cyx
reviewed
Jan 26, 2021
| @@ -200,12 +203,44 @@ func deleteRulesCmd(cli *cli) *cobra.Command { | |||
| Long: `Delete a rule: | |||
|
|
|||
| auth0 rules delete --id "12345"`, | |||
| PreRunE: func(cmd *cobra.Command, args []string) error { | |||
| if flags.id != "" && flags.name != "" { | |||
| return fmt.Errorf("TMI! 🤯 use either --name or --id") | |||
cyx
reviewed
Jan 26, 2021
Comment on lines
+214
to
+215
| ruleIDPattern := "^rul_[A-Za-z0-9]{16}$" | ||
| re := regexp.MustCompile(ruleIDPattern) |
There was a problem hiding this comment.
Not a big deal since this is a CLI, but typically you put MustCompile lines in vars outside so you don't have to re-do it.
(We can keep it like this for this PR though, just wanted to share that compiling regexp is typically expensive if you're doing server side code).
There was a problem hiding this comment.
Oh, that makes sense, good to know, ty!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close A0CLI-40