Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DXCDT-264: Add api command #531
DXCDT-264: Add api command #531
Changes from 1 commit
9aa0451
2f77662
26eec53
96dd7b2
042face
15bb5a9
dd53121
e41cde6
eae2bbe
b16e634
2e5ac1e
b56f661
304faa1
b1b346e
f401dfd
9510219
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
String interpolation with
apiValidMethods
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated in:
2f776626
(#531)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a functional distinction between
Method
andRawMethod
or than symmetry with the other arguments? If not, maybe consider removing it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RawMethod
hasn't been validated yet andMethod
is validated.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similarly to other feedback, this error could be more human friendly. I think we'd have a good idea of when and how this error triggers, so we could provide clearer guidance on how to correct.
See: https://clig.dev/#errors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The returned error wraps all inner errors so the final one ends up to be for example:
What do you suggest so we make it more human friendly? As in this case it's particularly hard as the
json.Valid
just returns true or false and isn't able to tell that the input was missing a"
.