Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: actions promote and actions versions #53

Merged
merged 5 commits into from
Jan 27, 2021

Conversation

turcottedanny
Copy link
Contributor

@turcottedanny turcottedanny commented Jan 26, 2021

By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

image

References

https://auth0team.atlassian.net/browse/A0CLI-41

Testing

Describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

Please include any manual steps for testing end-to-end or functionality not covered by unit/integration tests.

Also include details of the environment this PR was developed in (language/platform/browser version).

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@turcottedanny
Copy link
Contributor Author

image

internal/cli/actions.go Outdated Show resolved Hide resolved
Copy link
Contributor

@cyx cyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to s/promote/deploy for product facing consistency, but otherwise :shipit:

@turcottedanny turcottedanny merged commit bdd629e into main Jan 27, 2021
@turcottedanny turcottedanny deleted the A0CLI-41-actions-promote branch January 27, 2021 02:06
@cyx
Copy link
Contributor

cyx commented Jan 27, 2021

Thanks for doing this! 👍 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants