fix: remove --reveal flag from try-login, always show tokens #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@paddycarey Does it make sense to make it optional? Might be useful for demo purposes/screen shares. |
|
@vprasanth perhaps, though I think it's worth removing for now and we can rethink CLI-wide redaction in another ticket as we need it. |
vprasanth
approved these changes
Jan 26, 2021
cyx
approved these changes
Jan 26, 2021
paddycarey
force-pushed
the
remove-reveal-flags
branch
from
2ff3dd0 to
5778604
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.