fix: auth0 tenants add: blank slate #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the blank slate case, we don't want it to error out if there are no tenants since by definition we have no tenants configured.
cyx
commented
Feb 5, 2022
Comment on lines
+170
to
+172
| if !errors.Is(err, errUnauthenticated) { | ||
| return err | ||
| } |
There was a problem hiding this comment.
In the event we get a different type of error we won't silence it accidentally. For this case, we only care about errUnauthenticated.
cyx
commented
Feb 5, 2022
Comment on lines
+174
to
+176
| if err := tenantDomain.Ask(cmd, &inputs.Domain); err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
We revert to a basic prompt since there's no "list" of tenants yet to formulate / present.
Widcket
approved these changes
Feb 5, 2022
tylernix
pushed a commit
that referenced
this pull request
Mar 17, 2022
For the blank slate case, we don't want it to error out if there are no tenants since by definition we have no tenants configured.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For the blank slate case, we don't want it to error out if there are no
tenants since by definition we have no tenants configured.
References
#392
Testing
rm -rf ~/.config/auth0auth0 tenants addYou should be prompted, instead of seeing an error.
Checklist
master