Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have the login command honor the --no-input flag [DXCDT-15] #390

Merged
merged 2 commits into from
Jan 24, 2022

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Jan 21, 2022

Description

The --no-input flag is meant to disable interactivity. This PR has the auth0 login command honor this flag so as to not automatically open the login URL in the default browser, but print it instead. This allows the use of any browser for login.

Screen Shot 2022-01-21 at 18 45 44

The regular, interactive login continues to work normally:

Screen Shot 2022-01-21 at 18 38 01

References

Fixes #371

Testing

The change was tested manually.

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@Widcket Widcket requested a review from sergiught January 21, 2022 22:23
Copy link
Contributor

@sergiught sergiught left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thanks @Widcket!

@Widcket Widcket merged commit f89c425 into main Jan 24, 2022
@Widcket Widcket deleted the feature/non-interactive-login branch January 24, 2022 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow manually pasting the sign-in url to make it easier to sign in in a different browser
2 participants