[A0CLI-7] feat: Add ability to specify single connection for try-login #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paddycarey
changed the title
paddycarey
commented
Jan 26, 2021
internal/cli/try_login.go
Outdated
| ctx, cancel := context.WithTimeout(context.Background(), 5*time.Second) | ||
| defer cancel() | ||
| defer func() { _ = s.Shutdown(ctx) }() |
There was a problem hiding this comment.
We don't actually care about the error here if there is one. The process will tear down immediately after this anyway and bring the server down with it regardless 🤷🏻
cyx
approved these changes
Jan 26, 2021
internal/cli/try_login.go
Outdated
| cli.renderer.TryLogin(userInfo, tokenResponse, reveal) | ||
| return nil | ||
| }, | ||
| } | ||
|
|
||
| cmd.SetUsageTemplate(resourceUsageTemplate()) | ||
| cmd.Flags().StringP("client-id", "c", "", "Client ID for which to test login.") | ||
| cmd.Flags().BoolP("reveal", "r", false, "⚠️ Reveal tokens after successful login.") | ||
| cmd.Flags().StringVarP(&clientID, "clinet-id", "c", "", "Client ID for which to test login.") |
| cmd.Flags().BoolP("reveal", "r", false, "⚠️ Reveal tokens after successful login.") | ||
| cmd.Flags().StringVarP(&clientID, "clinet-id", "c", "", "Client ID for which to test login.") | ||
| cmd.Flags().StringVarP(&connectionName, "connection", "", "", "Connection to test during login.") | ||
| cmd.Flags().BoolVarP(&reveal, "reveal", "r", false, "⚠️ Reveal tokens after successful login.") |
There was a problem hiding this comment.
I wasn't really sure what to use here tbh, c is already taken and not sure what else makes sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://auth0team.atlassian.net/browse/A0CLI-7
This PR adds the ability to specify a single connection when using
try-login. This allows easy testing of new connections.In addition, the PR also includes a fix to propagate errors from the callback request (the one intercepted by our local HTTP server) to the CLI, and updates flag usage to be more consistent with other commands (
StringVarPoverStringPetc.).