Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide global --tenant flag on login command [DXCDT-14] #388

Merged
merged 3 commits into from
Jan 24, 2022

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Jan 21, 2022

Description

This PR hides the --tenant global flag from the help of the auth0 login command.

The purpose of the --tenant flag is to allow CLI users to pick a tenant they’re already logged into to perform a specific operation – not to pick the tenant to log in to. This can easily be a source of confusion.

Marked as draft until #387 gets merged because we need to generate the updated docs, and that PR also includes docs.

Before

Screen Shot 2022-01-21 at 13 38 33

After

Screen Shot 2022-01-21 at 13 35 51

References

Closes #372

Testing

The change was tested manually.

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@Widcket Widcket requested a review from sergiught January 21, 2022 16:44
@Widcket Widcket marked this pull request as draft January 21, 2022 16:44
Copy link
Contributor

@sergiught sergiught left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks @Widcket !

@Widcket Widcket marked this pull request as ready for review January 24, 2022 13:48
@Widcket Widcket merged commit 57001ee into main Jan 24, 2022
@Widcket Widcket deleted the fix/hide-tenant-flag-login branch January 24, 2022 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

auth-cli login doesnt respect tenant
2 participants