Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed role alias #358

Merged
merged 2 commits into from
Sep 21, 2021
Merged

Removed role alias #358

merged 2 commits into from
Sep 21, 2021

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Sep 21, 2021

Description

This PR removes the role alias from the roles command, as the roles command is already short enough and an alias with 1 character less is not justified, and does not follow from the other aliases:

Screen Shot 2021-09-21 at 17 13 44

THIS IS A BREAKING CHANGE.

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@Widcket Widcket requested a review from jfatta September 21, 2021 20:16
jfatta
jfatta approved these changes Sep 21, 2021
View reviewed changes
Copy link
Contributor

@jfatta jfatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense 👍🏼

@Widcket Widcket merged commit 343e7b3 into main Sep 21, 2021
@Widcket Widcket deleted the remove/role-alias branch September 21, 2021 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfatta jfatta jfatta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Widcket @jfatta