Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed API fetching logic in roles permissions add/rm #357

Merged
merged 1 commit into from
Sep 21, 2021
Merged

Fixed API fetching logic in roles permissions add/rm #357

merged 1 commit into from
Sep 21, 2021

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Sep 21, 2021 •
edited
Loading

Description

This PR changes the way the API is fetched from the Management API in roles permissions add and roles permissions rm so that it will be done even when passing an API Identifier via flag. The previous implementation only worked correctly when the command was used interactively.

Add

Screen Shot 2021-09-21 at 17 00 05

Screen Shot 2021-09-21 at 16 59 28

Remove

Screen Shot 2021-09-21 at 17 00 44

Screen Shot 2021-09-21 at 17 00 58

References

Fixes #348

Testing

This change was tested manually.

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@Widcket Widcket requested a review from jfatta September 21, 2021 20:06
jfatta
jfatta approved these changes Sep 21, 2021
View reviewed changes
Copy link
Contributor

@jfatta jfatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Widcket Widcket merged commit 80c6deb into main Sep 21, 2021
@Widcket Widcket deleted the fix/roles-permissions branch September 21, 2021 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfatta jfatta jfatta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Uncertain if specifying api-id is just unclear or broken when adding permissions to a role
2 participants
@Widcket @jfatta