Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pkg/browser to open URLs #347

Merged
merged 1 commit into from
Sep 1, 2021
Merged

Use pkg/browser to open URLs #347

merged 1 commit into from
Sep 1, 2021

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Sep 1, 2021

Description

This PR uses pkg/browser to open URLs in the browser, as the current implementation was not working correctly on Windows.

References

Fixes #345

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@Widcket Widcket requested a review from jfatta September 1, 2021 02:55
jfatta
jfatta approved these changes Sep 1, 2021
View reviewed changes
Copy link
Contributor

@jfatta jfatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@Widcket Widcket merged commit 0f57d13 into main Sep 1, 2021
@Widcket Widcket deleted the fix/open-url branch September 1, 2021 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfatta jfatta jfatta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

invalid_request: missing required paramter: response_type on "test login" command
2 participants
@Widcket @jfatta