Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rule integration tests [CLI-163] #340

Merged
merged 11 commits into from
Jul 30, 2021
Merged

Add rule integration tests [CLI-163] #340

merged 11 commits into from
Jul 30, 2021

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Jul 27, 2021 •
edited
Loading

Description

This PR adds integration tests for rules create, rules update, rules show, rules enable and rules disable.

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@Widcket Widcket changed the title Add rule integration tests Add rule integration tests [CLI-163] Jul 27, 2021
@Widcket Widcket marked this pull request as ready for review July 27, 2021 23:30
@Widcket Widcket requested a review from jfatta July 27, 2021 23:30
jfatta
jfatta approved these changes Jul 30, 2021
View reviewed changes
Copy link
Contributor

@jfatta jfatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks.

@Widcket Widcket merged commit 7f578d8 into main Jul 30, 2021
@Widcket Widcket deleted the rules-integration-tests branch July 30, 2021 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfatta jfatta jfatta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Widcket @jfatta