Refactor editor prompt to unblock tests #330
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, it is not possible to add integration tests for any command that involves opening an external code editor, such as
rules create
orrules update
. The editor prompt does not honor the--no-input
flag, and we'd also need to add support for an alternative input method (e.g. piping).This PR tackles the first problem, by having the editor prompt use the same code infrastructure as the rest of the prompts. That makes the editor behave similarly to the other prompts, e.g honoring
--no-input
and handling errors the same way.Testing
Checklist
master