Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor editor prompt to unblock tests #330

Merged
merged 9 commits into from
Jul 17, 2021
Merged

Refactor editor prompt to unblock tests #330

merged 9 commits into from
Jul 17, 2021

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Jul 10, 2021

Description

Currently, it is not possible to add integration tests for any command that involves opening an external code editor, such as rules create or rules update. The editor prompt does not honor the --no-input flag, and we'd also need to add support for an alternative input method (e.g. piping).

This PR tackles the first problem, by having the editor prompt use the same code infrastructure as the rest of the prompts. That makes the editor behave similarly to the other prompts, e.g honoring --no-input and handling errors the same way.

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@Widcket Widcket marked this pull request as ready for review July 16, 2021 18:41
@Widcket Widcket requested a review from cyx July 16, 2021 18:41
Copy link
Contributor

@cyx cyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Is there a UX change or is it completely transparent?

@Widcket
Copy link
Contributor Author

Widcket commented Jul 17, 2021

It is transparent.

@Widcket Widcket merged commit ca258cc into main Jul 17, 2021
@Widcket Widcket deleted the refactor-editor branch July 17, 2021 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants