Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add organizations CRUD [CLI-189] #325

Merged
merged 11 commits into from
Jul 6, 2021
Merged

Add organizations CRUD [CLI-189] #325

merged 11 commits into from
Jul 6, 2021

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Jul 3, 2021

Description

This PR adds the following commands:

  • auth0 orgs list
  • auth0 orgs show
  • auth0 orgs create
  • auth0 orgs update
  • auth0 orgs delete
  • auth0 orgs open

Screen Shot 2021-07-02 at 19 20 29

Screen Shot 2021-07-02 at 19 21 27

Screen Shot 2021-07-02 at 19 21 52

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@Widcket Widcket requested a review from a team July 3, 2021 01:33
@Widcket Widcket changed the title Organizations crud Add organizations CRUD Jul 3, 2021
@Widcket Widcket changed the title Add organizations CRUD Add organizations CRUD [CLI-189] Jul 6, 2021
jfatta
jfatta approved these changes Jul 6, 2021
View reviewed changes
Copy link
Contributor

@jfatta jfatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job. I left a comment reg mocks, other than that :shipit:

internal/auth0/organization.go Outdated
@@ -0,0 +1,32 @@
//go:generate mockgen -source=organization.go -destination=organization_mock.go -package=auth0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you remove this and the following too? we're not using these mocks, and it would be nice to run make generate at any momento without unwanted changes
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in edcbfb8

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 🙇🏼

@Widcket Widcket merged commit daf7e30 into main Jul 6, 2021
@Widcket Widcket deleted the organizations-crud branch July 6, 2021 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfatta jfatta jfatta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Widcket @jfatta