docs: add favicon #324
Merged
docs: add favicon #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Widcket
reviewed
Jul 2, 2021
| @@ -0,0 +1,20 @@ | |||
| {%- if page.comments != false and jekyll.environment == "production" -%} | |||
There was a problem hiding this comment.
Is this file necessary if we don't use Disqus?
Widcket
reviewed
Jul 2, 2021
| @@ -0,0 +1,35 @@ | |||
| <footer class="site-footer h-card"> | |||
There was a problem hiding this comment.
Why are we adding a custom footer?
Widcket
reviewed
Jul 2, 2021
| @@ -0,0 +1,12 @@ | |||
| <script> | |||
Widcket
reviewed
Jul 2, 2021
| <link rel="icon" type="image/png" href="favicon.png"> | ||
| {%- feed_meta -%} | ||
| {%- if jekyll.environment == 'production' and site.google_analytics -%} | ||
| {%- include google-analytics.html -%} |
There was a problem hiding this comment.
Same as above, do we need GA?
Widcket
reviewed
Jul 2, 2021
| @@ -0,0 +1,14 @@ | |||
| <ul class="social-media-list"> | |||
There was a problem hiding this comment.
What are these for? Do we want this?
There was a problem hiding this comment.
Same for the above individual social icons.
There was a problem hiding this comment.
@Widcket, yes. To override one include, we need to replicate the entire folder structure here https://github.com/jekyll/minima/tree/master/_includes. It is a common practice with github themes until you have your own. I tried adding only the header to our _includes folder and the make start-doc process fails.
Widcket
approved these changes
Jul 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add auth0 favicon to docs homepage