Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: source auth vars from env #318

Merged
merged 11 commits into from
Jul 5, 2021
Merged

refactor: source auth vars from env #318

merged 11 commits into from
Jul 5, 2021

Conversation

as-herzog
Copy link
Contributor

@as-herzog as-herzog commented Jun 25, 2021 •
edited
Loading

Description

Source auth variables from env if provided. This allows us to use the cli with cloud deployments.

Screen Shot 2021-06-28 at 10 34 44 AM

Screen Shot 2021-06-28 at 10 34 17 AM

@as-herzog as-herzog marked this pull request as ready for review June 28, 2021 14:14
@as-herzog as-herzog requested review from Widcket and jfatta June 28, 2021 14:14
@as-herzog as-herzog changed the title pick up auth flow from env vars refactor: pick up auth vars from env Jun 28, 2021
jfatta
jfatta reviewed Jun 28, 2021
View reviewed changes
Copy link
Contributor

@jfatta jfatta left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work, this is going to unlock the CLi use with cloud deployments.

I left a suggestion to simplify the overall approach.

internal/auth/auth.go Outdated Show resolved Hide resolved
@as-herzog as-herzog changed the title refactor: pick up auth vars from env refactor: source auth vars from env Jun 28, 2021
jfatta
jfatta reviewed Jun 28, 2021
View reviewed changes
internal/auth/auth.go Outdated Show resolved Hide resolved
internal/auth/README.md Outdated Show resolved Hide resolved
@Widcket Widcket requested a review from jfatta June 30, 2021 06:31
jfatta
jfatta approved these changes Jul 2, 2021
View reviewed changes
Copy link
Contributor

@jfatta jfatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left minor suggestions, then I think is ready :shipit:

README.md Outdated Show resolved Hide resolved
internal/auth/token_test.go Outdated Show resolved Hide resolved
Widcket
Widcket approved these changes Jul 5, 2021
View reviewed changes
Copy link
Contributor

@Widcket Widcket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@Widcket Widcket merged commit 85d22b7 into main Jul 5, 2021
@Widcket Widcket deleted the CLI-188-auth-flow-env-vars branch July 5, 2021 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfatta jfatta jfatta approved these changes

@Widcket Widcket Widcket approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@as-herzog @Widcket @jfatta