Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace client-id with filter in logs commands #310

Merged
merged 2 commits into from
Jun 14, 2021
Merged

Replace client-id with filter in logs commands #310

merged 2 commits into from
Jun 14, 2021

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Jun 11, 2021

Description

This PR replaces the --client-id filter with a single --filter flag that takes a Lucene query string, like users search.

E.g.

auth0 logs list --filter "client_id:<client-id>"
auth0 logs list --filter "client_name:<client-name>"
auth0 logs list --filter "user_id:<user-id>"
auth0 logs tail --filter "user_name:<user-name>"
auth0 logs tail --filter "ip:<ip>"
auth0 logs tail --filter "type:f"

⚠️ THIS IS A BREAKING CHANGE

The alternative, which would have been to add a flag per valid filter field, would have meant having a bunch of flags that are mutually exclusive.

Screen Shot 2021-06-11 at 12 21 46

Screen Shot 2021-06-11 at 12 23 07

Screen Shot 2021-06-11 at 12 19 27

Screen Shot 2021-06-11 at 12 20 41

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@Widcket Widcket requested a review from a team June 11, 2021 15:33
Copy link
Contributor

@cyx cyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Widcket Widcket merged commit a23cbe7 into main Jun 14, 2021
@Widcket Widcket deleted the logs-filter branch June 14, 2021 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants