Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add scopes flag to test login [CLI-171] #305

Merged
merged 1 commit into from
May 29, 2021
Merged

Add scopes flag to test login [CLI-171] #305

merged 1 commit into from
May 29, 2021

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented May 29, 2021 •
edited
Loading

Description

This PR adds the flag --scopes to test login. The addition makes the CLI more useful for troubleshooting login issues.

Screen Shot 2021-05-28 at 22 42 37

Screen Shot 2021-05-28 at 22 47 23

Testing

This was tested manually by using a proxy to check the sent scopes.

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@Widcket Widcket requested a review from a team May 29, 2021 01:51
@Widcket Widcket changed the title Add scopes flag to test login Add scopes flag to test login [CLI-171] May 29, 2021
jfatta
jfatta approved these changes May 29, 2021
View reviewed changes
Copy link
Contributor

@jfatta jfatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Widcket Widcket merged commit d5cc934 into main May 29, 2021
@Widcket Widcket deleted the scopes-test-login branch May 29, 2021 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfatta jfatta jfatta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Widcket @jfatta