Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add roles #293

Merged
merged 6 commits into from
May 15, 2021
Merged

feat: add roles #293

merged 6 commits into from
May 15, 2021

Conversation

cyx
Copy link
Contributor

@cyx cyx commented May 14, 2021

Description

This PR adds list, show, create, update, delete commands for the role resource.

A quick demo is shown below showcasing all the commands.

asciicast

@cyx cyx changed the title Feat add roles feat: add roles May 14, 2021
@cyx cyx force-pushed the feat-add-roles branch from 4d4dc1c to e3b82d1 Compare May 14, 2021 23:05
Widcket
Widcket requested changes May 15, 2021
View reviewed changes
Copy link
Contributor

@Widcket Widcket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple of tiny details.

@cyx cyx force-pushed the feat-add-roles branch from d2e88d8 to 11bf1b9 Compare May 15, 2021 00:15
@cyx cyx merged commit 564f3ca into main May 15, 2021
@cyx cyx deleted the feat-add-roles branch May 15, 2021 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Widcket Widcket Widcket approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cyx @Widcket