chore: split ci into separate steps #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that we only run Snyk on pull requests right now, do we need to run the others on push or could we just run all of them on PR? |
cyx
reviewed
May 15, 2021
| runs-on: ubuntu-latest | ||
| # We want to run on external PRs, but not on our own internal PRs as they'll be run | ||
| # by the push to the branch. | ||
| if: github.event_name == 'push' || github.event.pull_request.head.repo.full_name != github.repository |
cyx
reviewed
May 15, 2021
Comment on lines
+10
to
+12
| # We want to run on external PRs, but not on our own internal PRs as they'll be run | ||
| # by the push to the branch. | ||
| if: github.event_name == 'push' || github.event.pull_request.head.repo.full_name != github.repository |
There was a problem hiding this comment.
Shouldn't we also avoid running this for external PRs? I guess what's our full intent?
cyx
approved these changes
May 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Splits up the
Buildstep to have separate steps forunit test,integration test, andbuildfor easier debugging. Also skips duplicate runs of each step due to our on push and on pull_request settings.Before:
After:
Reference
https://github.community/t/duplicate-checks-on-push-and-pull-request-simultaneous-event/18012