Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: config init command #291

Merged
merged 12 commits into from
Jun 14, 2021
Merged

feat: config init command #291

merged 12 commits into from
Jun 14, 2021

Conversation

as-herzog
Copy link
Contributor

@as-herzog as-herzog commented May 14, 2021 •
edited
Loading

Description

Adds auth0 config init command to initialize cli config from environment variables (non-interactive flow). This is a replacement for the cli-config-generator used in integration tests.

Screen Shot 2021-05-17 at 3 15 16 PM

@as-herzog as-herzog changed the title refactor: config generator for integration tests feat: config init command May 17, 2021
as-herzog
as-herzog commented May 17, 2021
View reviewed changes
internal/cli/config.go Outdated Show resolved Hide resolved
@as-herzog as-herzog requested a review from jfatta May 17, 2021 21:24
@as-herzog as-herzog marked this pull request as ready for review May 17, 2021 21:25
jfatta
jfatta reviewed May 18, 2021
View reviewed changes
internal/cli/config.go Outdated Show resolved Hide resolved
jfatta
jfatta reviewed May 18, 2021
View reviewed changes
pkg/auth0-cli-config-generator/main.go
@@ -1,224 +0,0 @@
// auth0-cli-config-generator: A command that generates a valid config file that can be used with auth0-cli.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it feels so good

@Widcket Widcket requested review from jfatta and a team May 21, 2021 21:52
jfatta
jfatta reviewed May 26, 2021
View reviewed changes
Copy link
Contributor

@jfatta jfatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(just re-submitting because I received the review request, my comments from the prev review are still relevant)

@as-herzog as-herzog requested a review from jfatta June 11, 2021 17:48
jfatta
jfatta approved these changes Jun 11, 2021
View reviewed changes
Copy link
Contributor

@jfatta jfatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I'd suggest flagging the new command as hidden just to prevent unnecessary usage from end-users.

@as-herzog as-herzog requested a review from Widcket June 11, 2021 19:14
Widcket
Widcket reviewed Jun 14, 2021
View reviewed changes
internal/cli/config.go Outdated Show resolved Hide resolved
Widcket
Widcket reviewed Jun 14, 2021
View reviewed changes
internal/cli/config.go Outdated Show resolved Hide resolved
Widcket
Widcket approved these changes Jun 14, 2021
View reviewed changes
Copy link
Contributor

@Widcket Widcket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@Widcket Widcket merged commit 54fc3f3 into main Jun 14, 2021
@Widcket Widcket deleted the CLI-165-refactor-config-gen branch June 14, 2021 16:20
@willvedd willvedd mentioned this pull request Nov 29, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfatta jfatta jfatta approved these changes

@Widcket Widcket Widcket approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@as-herzog @Widcket @jfatta