Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use updated token once after the renewal #290

Merged
merged 3 commits into from
May 14, 2021
Merged

fix: use updated token once after the renewal #290

merged 3 commits into from
May 14, 2021

Conversation

jfatta
Copy link
Contributor

@jfatta jfatta commented May 14, 2021

Fix bug regarding old access token being used after the renewal process due to expiration or scopes changed.

before
image

after
image

cyx
cyx approved these changes May 14, 2021
View reviewed changes
Copy link
Contributor

@cyx cyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍

@Widcket Widcket merged commit 7fe639a into main May 14, 2021
@Widcket Widcket deleted the fix-expired-token branch May 14, 2021 21:32
@Widcket
Copy link
Contributor

Widcket commented May 14, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Widcket Widcket Widcket approved these changes

@cyx cyx cyx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jfatta @Widcket @cyx