Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add auth0.Error [CLI-156] #285

Merged
merged 1 commit into from
May 10, 2021
Merged

Add auth0.Error [CLI-156] #285

merged 1 commit into from
May 10, 2021

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented May 8, 2021

Description

This PR adds a method that wraps every error passed to panic to decorate it with a stack trace, using the github.com/pkg/errors package.

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@Widcket Widcket requested a review from a team May 8, 2021 01:34
cyx
cyx approved these changes May 10, 2021
View reviewed changes
Copy link
Contributor

@cyx cyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We'll probably want to change all fmt.Errorf calls in a separate PR but this is 👍 for now

@Widcket Widcket merged commit 77c96d3 into main May 10, 2021
@Widcket Widcket deleted the auth0-error branch May 10, 2021 15:40
@Widcket
Copy link
Contributor Author

Widcket commented May 10, 2021

Looks good! We'll probably want to change all fmt.Errorf calls in a separate PR but this is 👍 for now

Will the errors we print to the users be affected (show the stack trace)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyx cyx cyx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Widcket @cyx