Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update messaging for login command #268

Merged
merged 1 commit into from
Apr 28, 2021
Merged

Update messaging for login command #268

merged 1 commit into from
Apr 28, 2021

Conversation

chrisscott
Copy link
Contributor

Description

  • Be more clear on the next step
  • Use Device Confirmation instead of pairing to match language on the Universal Login page
  • Use a spinner while waiting for login to complete in the browser
  • Be more concise

Before
login-before

After
login

References

CLI-135

Testing

Test login command to completion and also canceling it out.

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not main

@chrisscott
Update messaging for login command to be more clear on the next step.…
6488b25 
… Use a spinner while waiting for login to complete in the browser.
Widcket
Widcket approved these changes Apr 28, 2021
View reviewed changes
Copy link
Contributor

@Widcket Widcket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you! Nicely done 👍🏼

@Widcket Widcket merged commit 781f245 into main Apr 28, 2021
@Widcket Widcket deleted the cli-135-login-messaging branch April 28, 2021 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Widcket Widcket Widcket approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrisscott @Widcket