CLI-140: integration tests on ci #263
Conversation
as-herzog
changed the title
…uth0-cli into cli-140-integration-on-ci
| AUTH0_CLI_CLIENT_DOMAIN: ${{ secrets.AUTH0_CLI_CLIENT_DOMAIN }} | ||
| AUTH0_CLI_CLIENT_ID: ${{ secrets.AUTH0_CLI_CLIENT_ID }} | ||
| AUTH0_CLI_CLIENT_SECRET: ${{ secrets.AUTH0_CLI_CLIENT_SECRET }} | ||
| AUTH0_CLI_REUSE_CONFIG: ${{ secrets.AUTH0_CLI_REUSE_CONFIG }} |
There was a problem hiding this comment.
I'm not sure if we need AUTH0_CLI_REUSE_CONFIG on the secrets. It should be always false on CI if understood the code correctly; there's no config file to reuse here.
There was a problem hiding this comment.
what if we tweak the CLI codebase to look for all those ENV vars and skip the config file completely if the vars are present?
There was a problem hiding this comment.
nvm, we don't want to support client id/secret auth mechanism on the code base. In any case, it could look for an ENV var with the access token and skip config file, but that has nothing to do with this PR.
| @@ -38,11 +38,7 @@ lint: | |||
|
|
|||
| # Build for the native platform | |||
| build: | |||
| go build -ldflags "$(CTIMEVAR)" -o auth0 cmd/auth0/main.go | |||
There was a problem hiding this comment.
good catch. bad resolved merge conflict I guess 🤦🏼
| Domain: p.clientDomain, | ||
| AccessToken: token.AccessToken, | ||
| ExpiresAt: token.Expiry, | ||
| Scopes: requiredScopes, |
There was a problem hiding this comment.
the CLI is triggering a login flow if the scopes on the tenant are not equal to the defined on the auth package, this is a way we have to "revalidate" tokens if we change the scopes used.
Evidently, it would be hard to maintain (keep in sync) the config generator regarding tenant and other login details.
I would like to explore that alternative of skipping all file-related config if an access token is defined. That way the generator would be repurposed on a command to login and write the access token to a var, no need to know the tenant entity at all.
Makefile
Outdated
| .PHONY: run-integration | ||
|
|
||
| # Delete all test apps created during integration testing | ||
| integration-cleanup: | ||
| ./integration/test-cleanup.sh | ||
| .PHONY: integration-cleanup | ||
|
|
||
| integration: $(GOBIN)/auth0-cli-config-generator $(GOBIN)/commander run-integration integration-cleanup | ||
| integration: build $(GOBIN)/auth0-cli-config-generator $(GOBIN)/commander run-integration integration-cleanup |
There was a problem hiding this comment.
@as-herzog I kept the integration-cleanup when I solved merge conflicts. But I think that is swallowing potential error reports from commander when tests failed.
Description
Runs integration tests in CI but skips them for forked PRs:
Forked ex:
References
https://auth0team.atlassian.net/browse/CLI-140