fix: wrong jwtconfig lifetime type #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfatta
commented
Apr 23, 2021
| // Step 1: Setup our client mock for this test. We only care about | ||
| // Clients so no need to bootstrap other bits. | ||
| ctrl := gomock.NewController(t) | ||
| defer ctrl.Finish() | ||
|
|
||
| clientAPI := auth0.NewMockClientAPI(ctrl) | ||
| clientAPI.EXPECT(). | ||
| List(). | ||
| List(gomock.Any()). |
There was a problem hiding this comment.
creating a matcher for this can be really tricky because it is a function that takes a request and apply the changes. I don't it would add a fundamental value to the test, but let me know
|
Tried it with Proxyman (key not found in res body) 👍🏼
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exclude the
jwt_configuration.lifetime_in_secondsfile from the Clients.List operation.We experienced the following error in some cases:
From the investigation, it seems that legacy application are returning a
jwt_configuration.lifetime_in_secondsof type string instead of *int. Since this field is not used on the CLI, we can safely ignore it for now.verifying that the field is being excluded
apps list command working as expected since the excluded field is not used
replicated the issue when logged with a github account, and listing a pretty old application