Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: login when scopes changed #261

Merged
merged 2 commits into from
Apr 23, 2021
Merged

feat: login when scopes changed #261

merged 2 commits into from
Apr 23, 2021

Conversation

jfatta
Copy link
Contributor

@jfatta jfatta commented Apr 23, 2021

Check if the required scopes changed and re-triggers the login flow in that case.

The scopes used are persisted on the config (tenant entity) just like the expiration date.

first time running this version will trigger a login since the config files are outdated

running any command with scopes out of date
image

scopes persisted
image

after that, until scopes change again, the login is not required
image

Copy link
Contributor

@Widcket Widcket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jfatta jfatta merged commit 0f4fee7 into main Apr 23, 2021
@jfatta jfatta deleted the feat-login-on-scope-change branch April 23, 2021 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants