Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[A0CLI-24] Add connections list command #26

Merged
merged 3 commits into from
Jan 25, 2021
Merged

[A0CLI-24] Add connections list command #26

merged 3 commits into from
Jan 25, 2021

Conversation

chrisscott
Copy link
Contributor

cyx
cyx approved these changes Jan 25, 2021
View reviewed changes
Copy link
Contributor

@cyx cyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@chrisscott chrisscott merged commit d455924 into main Jan 25, 2021
@chrisscott chrisscott deleted the feature/connections-list branch January 25, 2021 21:29
woloski
woloski reviewed Jan 25, 2021
View reviewed changes
internal/display/connections.go
}

func (v *connectionView) AsTableHeader() []string {
return []string{"Name", "Type", "ClientID"}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be Connection ID?

@chrisscott
Copy link
Contributor Author

🤦 good catch. Thanks, I'll put in a patch.

@chrisscott
Copy link
Contributor Author

Fixed in #27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woloski woloski woloski left review comments

@cyx cyx cyx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chrisscott @cyx @woloski