Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: polling faster error #252 #259

Merged
merged 2 commits into from
Apr 23, 2021
Merged

fix: polling faster error #252 #259

merged 2 commits into from
Apr 23, 2021

Conversation

jfatta
Copy link
Contributor

@jfatta jfatta commented Apr 23, 2021 •
edited
Loading

Adding a threshold to prevent this error:

login error: You are polling faster than the specified interval of (...)

fixes #252

image

Widcket
Widcket reviewed Apr 23, 2021
View reviewed changes
Copy link
Contributor

@Widcket Widcket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we set the leeway to 2 seconds, does it keep occurring?

@jfatta
Copy link
Contributor Author

jfatta commented Apr 23, 2021

If we set the leeway to 2 seconds, does it keep occurring?

it is tricky because I couldn't replicate this.

Widcket
Widcket approved these changes Apr 23, 2021
View reviewed changes
Copy link
Contributor

@Widcket Widcket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, let's err on the safer side.

@jfatta jfatta merged commit 0ec6677 into main Apr 23, 2021
@jfatta jfatta deleted the fix-polling-faster branch April 23, 2021 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Widcket Widcket Widcket approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

login error: You are polling faster than the specified interval of 5 seconds
2 participants
@jfatta @Widcket