Add tenants open and apis open [CLI-101] [CLI-133]
#253
Conversation
| } | ||
|
|
||
| // Heuristics to determine if this a valid ID, or an audience value | ||
| if _, err := url.ParseRequestURI(inputs.ID); err == nil || len(inputs.ID) != 24 { |
There was a problem hiding this comment.
what's 24coming from ? is inputs.ID a url? in that case I wonder if we can make it more explicit on the command help
There was a problem hiding this comment.
24 is the string length of the ID. Audiences are usually URLs, but not necessarily, so there is that additional heuristic to help disambiguate. I'll make it more explicit on the command help and add a comment explaining the values, thanks!
| inputs.ID = auth0.StringValue(api.ID) | ||
| return nil | ||
| }); err != nil { | ||
| return fmt.Errorf("An unexpected error occurred while trying to get the API Id for '%s': %w", inputs.ID, err) |
There was a problem hiding this comment.
NAB: I know we're doing this in other places already, but I'd suggest starting error messages with lowercase (as well as avoiding ending punctuation). More context here: https://github.com/golang/go/wiki/CodeReviewComments#error-strings
There was a problem hiding this comment.
Yes, the thing is that the reasoning behind that best practice is that errors are usually printed among other information, so there should not be a sentence-cased string in the middle of other text. In this particular case, that error message is going to be shown as-is, so we want the casing. We'll totally revisit this in the future, though, when we rethink the error handling.
| @@ -669,7 +667,7 @@ func openAppCmd(cli *cli) *cobra.Command { | |||
| Args: cobra.MaximumNArgs(1), | |||
| Short: "Open application settings page in Auth0 Manage", | |||
| Long: "Open application settings page in Auth0 Manage.", | |||
| Example: `auth0 apps open <id>`, | |||
| Example: "auth0 apps open <id>", | |||
There was a problem hiding this comment.
from prev comment, If id could adopt different forms (I'm not sure) I'd suggest including some placeholders here in the example section.
There was a problem hiding this comment.
I went with auth0 apps open <id|audience> in 62c64d5
| func (c *cli) tenantPickerOptions() (pickerOptions, error) { | ||
| tens, err := c.listTenants() | ||
| if err != nil { | ||
| return nil, fmt.Errorf("Unable to load tenants due to an unexpected error: %w", err) |
Co-authored-by: Jorge L. Fatta <[email protected]>
Description
This PR adds the following commands:
tenants openthat opens the tenant's settings page on the Dashboard. It takes the tenant's domain as a parameter.apis openthat opens the API's settings page on the Dashboard. It takes either the API Id or audience as a parameter.This is important as it provides a handy escape hatch, because the CLI does not support every parameter available for APIs, and does not allow to configure tenants ATM.
This PR also fixes a bug that caused the open logic to not work with PUS1 tenants, that do not have the region in the URL.
Testing
Checklist
master