feat: adds app open [id] command #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as-herzog
commented
Apr 16, 2021
| return cmd | ||
| } | ||
|
|
||
| func formatManageURL(cfg config, id string) string { |
There was a problem hiding this comment.
Not very familiar with manage, is there a better way to get this?
There was a problem hiding this comment.
Also, could you please move this function (and manageDomain) to the open package? https://github.com/auth0/auth0-cli/blob/main/internal/open/open.go
|
Think this looks good, and works well enough for today's use case. Not sure how it would work with private installs, but that doesn't work well altogether anyway, so maybe we can tackle all that later on. |
cyx
approved these changes
Apr 16, 2021
|
Thanks! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
apps open <clientID>command for opening the app settings page in Manage (browser).