Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README [CLI-134] #249

Merged
merged 2 commits into from
Apr 16, 2021
Merged

Update README [CLI-134] #249

merged 2 commits into from
Apr 16, 2021

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Apr 16, 2021

Description

This PR updates the GIF in the README, adds a Features section, and adds installation instructions for Windows with Scoop.

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@Widcket Widcket requested a review from a team April 16, 2021 13:43
@Widcket Widcket changed the title Update README Update README [CLI-134] Apr 16, 2021
vprasanth
vprasanth reviewed Apr 16, 2021
View reviewed changes
README.md Outdated
With the Auth0 CLI, you can:

- Manage your Auth0 applications, rules, and APIs right from the terminal.
- Create, update and delete resources interactively.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pedantic nit: I think there should be a comma after the update, but before and. Create, update, and delete...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks!

@Widcket Widcket merged commit 7724d59 into main Apr 16, 2021
@Widcket Widcket deleted the update-readme-scoop branch April 16, 2021 13:55
jfatta
jfatta approved these changes Apr 16, 2021
View reviewed changes
Copy link
Contributor

@jfatta jfatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we ok with the client displayed on the GIF?

(minor/not a blocker, consider waiting a couple of secs before stopping the gif creation, that way the reader have some time to understand what's happening)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfatta jfatta jfatta approved these changes

@vprasanth vprasanth vprasanth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Widcket @vprasanth @jfatta