Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style auth0 test login post-login page [CLI-126] #247

Merged
merged 3 commits into from
Apr 14, 2021
Merged

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Apr 14, 2021

Description

This PR styles the post-login page of the auth0 test login command, following the style of https://auth0.auth0.com/device/success

Screen.Cast.2021-04-14.at.5.19.20.PM.mp4

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@Widcket Widcket requested a review from a team April 14, 2021 20:22
@@ -62,3 +66,106 @@ func WaitForBrowserCallback(addr string) (code string, state string, err error)
return "", "", err
}
}

func resultPage(title string, message string, iconClass string) string {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, we'd want this in an embedded HTML file, but for the time being (with the Friday launch near) this can do.

Copy link
Contributor

@cyx cyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔆

@Widcket Widcket merged commit 4059a1e into main Apr 14, 2021
@Widcket Widcket deleted the style-login-page branch April 14, 2021 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants