Use domains for tenant name in config.json and for display #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… selection for `tenant use` if no selection is made.
|
@chrisscott |
|
Other than that, I've followed the test steps and it works fine 💪🏻
|
Widcket
reviewed
Apr 9, 2021
| } | ||
|
|
||
| input := prompt.SelectInput("tenant", "Tenant:", "Tenant to activate", tenNames, "", true) | ||
| input := prompt.SelectInput("tenant", "Tenant:", "Tenant to activate", tenNames, tenNames[0], true) |
|
Thanks for doing this 💪🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, fix a bug and use first selection for
tenant useif no selection is made.Description
Use the domain name instead of tenant name for display and re-key config.json to use domain instead of name for the
tenantsobject.References
https://auth0team.atlassian.net/browse/CLI-130
Testing
Remove your config file as this contains breaking changes
Login
tenants listtenants useLogin to another tenant and repeat the above commands, using a different tenant
Verify the default tenant is set correctly in your config
Use other commands that show the tenant header and verify the domain is displayed instead of the tenant name (e.g.
apis listLogout
Verify logged out tenant is removed from the config and the default is set correctly
This change adds test coverage for new/changed/fixed functionality
Checklist
master