fix: escape sequences on windows powershell #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfatta
commented
Apr 5, 2021
| @@ -13,6 +13,7 @@ require ( | |||
| github.com/golang/mock v1.5.0 | |||
| github.com/golang/snappy v0.0.3 // indirect | |||
| github.com/google/go-cmp v0.5.5 | |||
| github.com/kballard/go-shellquote v0.0.0-20180428030007-95032a82bc51 | |||
There was a problem hiding this comment.
apparently we missed a go mod vendor from previous PRs
Widcket
reviewed
Apr 5, 2021
Co-authored-by: Rita Zerrizuela <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix escape sequences for powershell. With this custom initialization for windows the newlines and colors are displayed properly. On the other hand, emojis are still missing due to a powershell default settings limitation according to this: https://stackoverflow.com/questions/49476326/displaying-unicode-in-powershell/49481797#49481797
before
after
