Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ask for rule enable/disable on 'rules update' #233

Merged
merged 1 commit into from
Apr 3, 2021
Merged

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Apr 3, 2021

Description

This PR modifies rules update to ask the user if the rule should be enabled or disabled, as there's no way to accomplish that interactively (at least until we add rules enable and rules disable).
Also removes the ? from the editor prompt, to match all other prompts.

Screen Shot 2021-04-02 at 20 54 48

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@Widcket Widcket requested a review from a team April 3, 2021 00:04
@Widcket Widcket merged commit 804d3b6 into main Apr 3, 2021
@Widcket Widcket deleted the ask-rule-enabled branch April 3, 2021 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants