rules editor create/update tweaks #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
== Description This adds basic changes for the create/update path. For now we're keeping them separate with an assertion that we want the straightforward edit paths to bypass the survey bits -- since that becomes unnecessary (e.g. when creating a rule, there's only way to do that -- and that's by editing the rule). For update, we'll utilize the surveyext bits heavily bollowed from github to have the `?` prompt.
cyx
force-pushed
the
editor-prompt-changes
branch
from
9bd2040 to
eb3e4f1
Compare
Widcket
reviewed
Apr 2, 2021
Co-authored-by: Rita Zerrizuela <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds basic changes for the create/update path. For now we're
keeping them separate with an assertion that we want the straightforward
edit paths to bypass the survey bits -- since that becomes unnecessary
(e.g. when creating a rule, there's only way to do that -- and that's by
editing the rule).
For update, we'll utilize the surveyext bits heavily bollowed from
github to have the
?prompt.Demo