Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the resource template on tenants commands #228

Merged
merged 4 commits into from
Apr 2, 2021
Merged

Use the resource template on tenants commands #228

merged 4 commits into from
Apr 2, 2021

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Apr 2, 2021

Description

The tenants commands were not using the resource template, defaulting to the namespace template.
This PR has those commands use the resource templates, and adds [flags] to the usage templates.

Before

Screen Shot 2021-04-02 at 16 01 38

After

Screen Shot 2021-04-02 at 16 03 27

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@Widcket Widcket requested a review from a team April 2, 2021 19:05
cyx
cyx approved these changes Apr 2, 2021
View reviewed changes
Copy link
Contributor

@cyx cyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great eye!

@Widcket
Copy link
Contributor Author

Widcket commented Apr 2, 2021 •
edited
Loading

Great eye!

That's from Sandrino's feedback doc

@Widcket Widcket merged commit ce04d9b into main Apr 2, 2021
@Widcket Widcket deleted the use-resource-template-tenants branch April 2, 2021 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyx cyx cyx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Widcket @cyx