Do not wrap 'logged out' error #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as-herzog
approved these changes
Apr 2, 2021
| @@ -21,7 +21,7 @@ func logoutCmd(cli *cli) *cobra.Command { | |||
| if len(args) == 0 { | |||
| tens, err := cli.listTenants() | |||
| if err != nil { | |||
| return fmt.Errorf("Unable to load tenants due to an unexpected error: %w", err) | |||
| return err // This error is already formatted for display | |||
There was a problem hiding this comment.
Is it possible for another err other than errUnauthenticated to be returned? Do we need to check that it is that error?
There was a problem hiding this comment.
Good Q @aherzog-auth0 . It boils down to two other error types:
- json.Unmarshal
- os.ReadFile
If we want this to be complete, we can check errUnauthenticated, return it as is, otherwise do an error wrap with Unexpected error: %w type pattern.
What do you think @Widcket ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When running the
auth logoutcommand when there are no logged in tenants, the error message displayedUnable to load tenants due to an unexpected error: Not yet configured. Try 'auth0 login'.is not really appropriate as there are no tenants to load.This PR changes the error message to simply
Not logged in. Try 'auth0 login'..Testing
Checklist
master