Make the audience flag required in test token
#221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as-herzog
reviewed
Apr 2, 2021
internal/cli/test.go
Outdated
| @@ -157,7 +165,7 @@ func testTokenCmd(cli *cli) *cobra.Command { | |||
| Short: "Fetch a token for the given client and API", | |||
| Long: `Fetch an access token for the given client. | |||
| If --client-id is not provided, the default client "CLI Login Testing" will be used (and created if not exists). | |||
| Additionally, you can also specify the --audience and --scope to use.`, | |||
| Additionally, you can also specify the --audience (API Identifer) and --scope to use.`, | |||
There was a problem hiding this comment.
IMO Additionally, you can also specify makes it sound like this isn't required.
as-herzog
approved these changes
Apr 2, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the
test tokencommand, if the--audienceflag is missing, the command will produce no tokens unless there is a default audience set in the tenant.This PR makes that flag required, so that the command will always produce a token.
Testing
Checklist
master