Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix format=json being initialized #22

Merged
merged 1 commit into from
Jan 25, 2021
Merged

Fix format=json being initialized #22

merged 1 commit into from
Jan 25, 2021

Conversation

cyx
Copy link
Contributor

@cyx cyx commented Jan 25, 2021

The problem was as follows:

getLogin => calls init()
 init() => would initOnce, and then set Renderer.Format to empty

... later on

PersistentPreRun gets called, and initOnce no longer activates.

@cyx
Fix format=json being initialized
5cae44a 
The problem was as follows:

```
getLogin => calls init()
 init() => would initOnce, and then set Renderer.Format to empty

... later on

PersistentPreRun gets called, and initOnce no longer activates.
```
jfatta
jfatta approved these changes Jan 25, 2021
View reviewed changes
Copy link
Contributor

@jfatta jfatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks

@jfatta jfatta merged commit e605506 into main Jan 25, 2021
@jfatta jfatta deleted the fix-format-json branch January 25, 2021 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfatta jfatta jfatta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cyx @jfatta