Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not wrap logout error twice #214

Merged
merged 2 commits into from
Mar 30, 2021
Merged

Do not wrap logout error twice #214

merged 2 commits into from
Mar 30, 2021

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Mar 30, 2021 •
edited
Loading

Description

This PR returns the error from removeTenant as-is because it already has been formatted for display.

Before
Unexpected error logging out tenant: : Unexpected error clearing tenant information: secret not found in keyring

After
Unexpected error clearing tenant information: secret not found in keyring

Errors in general need some work.

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@Widcket Widcket requested a review from a team March 30, 2021 14:41
jpadilla
jpadilla approved these changes Mar 30, 2021
View reviewed changes
Copy link
Member

@jpadilla jpadilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch! ✨

@Widcket Widcket merged commit 2c2b578 into main Mar 30, 2021
@Widcket Widcket deleted the wrap-logout-error-once branch March 30, 2021 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpadilla jpadilla jpadilla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Widcket @jpadilla