Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prompt for allowed origins on SPA creation/update [CLI-105] #203

Merged
merged 1 commit into from
Mar 27, 2021
Merged

Prompt for allowed origins on SPA creation/update [CLI-105] #203

merged 1 commit into from
Mar 27, 2021

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Mar 27, 2021

Description

This PR adds support for prompting for Allowed Origins when creating or updating a SPA.

Screen Shot 2021-03-26 at 23 26 38

Screen Shot 2021-03-26 at 23 28 12

Screen Shot 2021-03-26 at 23 28 48

References

Fixes #193

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@Widcket Widcket requested a review from a team March 27, 2021 02:32
@Widcket Widcket changed the title Prompt for allowed origins on SPA creation/update Prompt for allowed origins on SPA creation/update [CLI-105] Mar 27, 2021
cyx
cyx approved these changes Mar 27, 2021
View reviewed changes
Copy link
Contributor

@cyx cyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Widcket Widcket merged commit 574d307 into main Mar 27, 2021
@Widcket Widcket deleted the allowed-origins-spa branch March 27, 2021 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyx cyx cyx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

when creating a SPA app set the allowed origins too
2 participants
@Widcket @cyx