Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render QS sample Markdown README [CLI-85] #202

Merged
merged 3 commits into from
Mar 27, 2021
Merged

Render QS sample Markdown README [CLI-85] #202

merged 3 commits into from
Mar 27, 2021

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Mar 27, 2021 •
edited
Loading

Description

After quickstarts download successfully downloaded the sample, this PR:

  • Uses the glamour library to pretty-print the sample app README.md to the console. This is so the developer can follow the README instructions to setup the app and run it.
  • Hints the user to cd into the sample app dir.

Screen Shot 2021-03-26 at 23 07 16

Screen Shot 2021-03-26 at 23 06 57

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@Widcket Widcket requested a review from a team March 27, 2021 02:17
cyx
cyx approved these changes Mar 27, 2021
View reviewed changes
Copy link
Contributor

@cyx cyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Widcket Widcket merged commit 6d76fcb into main Mar 27, 2021
@Widcket Widcket deleted the render-qs-readme branch March 27, 2021 02:37
@woloski
Copy link

woloski commented Mar 27, 2021

overdeliver!🔥

@cyx cyx mentioned this pull request Mar 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyx cyx cyx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Widcket @woloski @cyx