CLI-80: user-blocks commands with user_id #201
Conversation
|
|
||
| func userBlocksCmd(cli *cli) *cobra.Command { | ||
| cmd := &cobra.Command{ | ||
| Use: "user-blocks", |
There was a problem hiding this comment.
As a subcommand: auth0 users blocks
|
|
||
| var ( | ||
| userID = Argument{ | ||
| Name: "user_id", |
There was a problem hiding this comment.
| Name: "user_id", | |
| Name: "User ID", |
| var ( | ||
| userID = Argument{ | ||
| Name: "user_id", | ||
| Help: "user_id of the user.", |
There was a problem hiding this comment.
| Help: "user_id of the user.", | |
| Help: "Id of the user.", |
|
|
||
| func listUserBlocksByUserIdCmd(cli *cli) *cobra.Command { | ||
| var inputs struct { | ||
| user_id string |
There was a problem hiding this comment.
Please do not use snake_case
| } | ||
|
|
||
| cmd := &cobra.Command{ | ||
| Use: "listByUserId", |
There was a problem hiding this comment.
Please use list. Entire command should be auth0 users blocks list.
There was a problem hiding this comment.
we can list by user_id or list by email / phonenumber / user_identifier. It's a different API call, what would a good way to name the handle the two different input types?
There was a problem hiding this comment.
The command should accept any of these as a single argument, and then disambiguate. It's the easiest for the user, that remains unaware (as they should) of those implementation details.
There was a problem hiding this comment.
e.g. auth0 apis show accepts an API id or the audience.
There was a problem hiding this comment.
For the end user, there's no difference.
| cmd := &cobra.Command{ | ||
| Use: "listByUserId", | ||
| Args: cobra.MaximumNArgs(1), | ||
| Short: "List user-blocks by user_id", |
There was a problem hiding this comment.
Please do not include the API2 entities as-is, instead describe what the command does in the context of a single user.
There was a problem hiding this comment.
Assume the user knows nothing about API2.
| Use: "listByUserId", | ||
| Args: cobra.MaximumNArgs(1), | ||
| Short: "List user-blocks by user_id", | ||
| Long: `List user-blocks by user_id: |
|
|
||
| func deleteUserBlocksByUserIdCmd(cli *cli) *cobra.Command { | ||
| var inputs struct { | ||
| user_id string |
There was a problem hiding this comment.
Please do not use snake_case.
| } | ||
|
|
||
| cmd := &cobra.Command{ | ||
| Use: "deleteByUserId", |
There was a problem hiding this comment.
Please usedelete. Entire command should be auth0 users blocks delete.
| cmd := &cobra.Command{ | ||
| Use: "deleteByUserId", | ||
| Args: cobra.MaximumNArgs(1), | ||
| Short: "Delete all user-blocks by user_id", |
There was a problem hiding this comment.
Please do not include the API2 entities as-is, instead describe what the command does in the context of a single user.
There was a problem hiding this comment.
Assume the user knows nothing about API2.
| Use: "deleteByUserId", | ||
| Args: cobra.MaximumNArgs(1), | ||
| Short: "Delete all user-blocks by user_id", | ||
| Long: `Delete all user-blocks by user_id: |
| } | ||
|
|
||
| func (r *Renderer) UserBlocksList(userBlocks []*management.UserBlock) { | ||
| resource := "userBlocks" |
There was a problem hiding this comment.
| resource := "userBlocks" | |
| resource := "user blocks" |
|
|
||
| if len(userBlocks) == 0 { | ||
| r.EmptyState(resource) | ||
| r.Infof("No blocks for user.") |
There was a problem hiding this comment.
r.EmptyState(resource) and r.Infof("No blocks for user.") do the same thing, please remove the last one.
|
moving to branch on main repo |
Description
Add commands for managing user-blocks by user_id
References
https://auth0team.atlassian.net/browse/CLI-80
https://auth0.com/docs/api/management/v2#!/User_Blocks/delete_user_blocks
https://github.com/go-auth0/auth0/blob/master/management/user.go#L423-L449