Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: color code app types #196

Merged
merged 4 commits into from
Mar 27, 2021
Merged

feat: color code app types #196

merged 4 commits into from
Mar 27, 2021

Conversation

as-herzog
Copy link
Contributor

Description

Color codes app types when displayed in list and key-value pairs.

Screen Shot 2021-03-26 at 2 37 09 PM

References

#106

@Widcket Widcket requested a review from a team March 26, 2021 21:44
jfatta
jfatta approved these changes Mar 26, 2021
View reviewed changes
Copy link
Contributor

@jfatta jfatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍
I don't have strong opinions about the colors anyway 🕶️

Just a comment about constants, other than that feel free to merge.

internal/display/apps.go Show resolved Hide resolved
@Widcket Widcket merged commit cae65f6 into main Mar 27, 2021
@Widcket Widcket deleted the cli38-color-code-app-type branch March 27, 2021 00:38
@Widcket
Copy link
Contributor

Widcket commented Mar 27, 2021

Thanks!

@Widcket Widcket mentioned this pull request Mar 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfatta jfatta jfatta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@as-herzog @Widcket @jfatta