apps, apis, rules: first stab at generalizing picker options [CLI-82] #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is mostly an internal only change which extracts the behavior of having `pickers`. == TODO - [ ] Try it out with apps - [ ] Try it out with apis
cyx
commented
Mar 23, 2021
| @@ -0,0 +1,32 @@ | |||
| package cli | |||
|
|
|||
| type pickerOptions []pickerOption | |||
There was a problem hiding this comment.
The previous iteration using maps had an undesirable behavior that options get randomized on every run. Formalizing this data structure to a list to have a deterministic order -- but also having methods on the list simplifies the call sites.
Widcket
reviewed
Mar 23, 2021
This comment has been minimized.
This comment has been minimized.
cyx
force-pushed
the
rule-generalize-picker-options
branch
from
4ef31b2 to
6520c3a
Compare
cyx
force-pushed
the
rule-generalize-picker-options
branch
from
6520c3a to
f6ef9a8
Compare
cyx
changed the title
Widcket
reviewed
Mar 23, 2021
Widcket
reviewed
Mar 24, 2021
Widcket
reviewed
Mar 24, 2021
Widcket
requested changes
Mar 24, 2021
Widcket
reviewed
Mar 24, 2021
Widcket
reviewed
Mar 24, 2021
Widcket
reviewed
Mar 24, 2021
Widcket
reviewed
Mar 24, 2021
Widcket
reviewed
Mar 24, 2021
Widcket
reviewed
Mar 24, 2021
Widcket
reviewed
Mar 24, 2021
Widcket
reviewed
Mar 24, 2021
Co-authored-by: Rita Zerrizuela <[email protected]>
Widcket
reviewed
Mar 24, 2021
|
|
||
| return fmt.Errorf("Missing a required argument: %s", a.GetName()) | ||
| } | ||
|
|
||
| func askArgument(cmd *cobra.Command, i commandInput, value interface{}) error { | ||
| if canPrompt(cmd) { | ||
| return ask(cmd, i, value, nil, true) |
There was a problem hiding this comment.
Suggested change
| return ask(cmd, i, value, nil, true) | |
| return ask(cmd, i, value, nil, false) |
Widcket
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Demo