Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt for urls depending on app type [CLI-67] #180

Merged
merged 15 commits into from
Mar 22, 2021
Merged

Prompt for urls depending on app type [CLI-67] #180

merged 15 commits into from
Mar 22, 2021

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Mar 22, 2021

Description

Now apps create and apps update prompt for callback URLs, logout URLs and web origin URLs depending on the type of the app:

  • Native: Callback, Logout. No default value
  • SPA: Callback, Logout, Web Origins. Default value: http://localhost:3000
  • Regular Web App: Callback, Logout. Default value: http://localhost:3000
  • M2M: -

Also:

  • apps update and apis update now use the previous value of a parameter as the default value shown in the prompt.
  • Updated apps and apis commands to use the new Waiting spinner.

Default URLs on app create

Screen.Recording.2021-03-22.at.01.04.46.mov

Custom URLs on app create

Screen.Recording.2021-03-21.at.22.49.42.mov

Default URLs on app update

Screen.Recording.2021-03-21.at.22.29.48.mov

Custom URLs on app update

Screen.Recording.2021-03-21.at.22.30.41.mov

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@Widcket Widcket requested a review from a team March 22, 2021 02:44
@Widcket Widcket merged commit 3c06146 into main Mar 22, 2021
@Widcket Widcket deleted the ask-many branch March 22, 2021 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants