Show scopes in apis subcommands instead of count
#174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n terminal width, to show the scopes instead of the count. Use an ellipsis to shdenote the truncation. For the `apis show` subcommand, add an info to note that the full scopes can be viewed using `auth0 apis scopes list <api-id>`.
Widcket
reviewed
Mar 20, 2021
Widcket
reviewed
Mar 20, 2021
Widcket
requested changes
Mar 20, 2021
… list may be truncated.
Widcket
reviewed
Mar 22, 2021
Widcket
reviewed
Mar 22, 2021
internal/display/apis.go
Outdated
| @@ -110,3 +155,35 @@ func makeScopeView(scope *management.ResourceServerScope) *scopeView { | |||
| Description: auth0.StringValue(scope.Description), | |||
| } | |||
| } | |||
|
|
|||
| func truncateScopes(scopes []*management.ResourceServerScope) *string { | |||
There was a problem hiding this comment.
Scopes that fit shouldn't be truncated.
Also let's not display the hint if the scopes are not truncated.
There was a problem hiding this comment.
🤦 good catch. Refactoring this now to bring the hint into the display logic instead of the cli logic.
Widcket
requested changes
Mar 22, 2021
… truncation when the scopes are actually truncated. Don't truncate scopes that fit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
apissubcommands that show scopes use a truncated list, based on terminal width, to show the scopes instead of the count. Use an ellipsis to denote the truncation.apis showsubcommand, add an info to note that the full scopes can be viewed usingauth0 apis scopes list <api-id>.The truncation function handles conversion of the length of UTF strings to characters and truncates based on terminal width. If truncation is needed by other commands this can be refactored.
There is an off by one bug in the truncation but it errs on the side of truncating too much so won't affect display.
The padding for the left column of the table is fixed but could be refactored to use reflection to determine the max length of the
apiViewstruct and apply the pre- and post-spacing in the display to account for future additions to the struct.References
Fixes #150
Checklist
master